Removing –clean switch from build.py

Forums Development Removing –clean switch from build.py

This topic contains 3 replies, has 2 voices, and was last updated by  CiaranG 1 year, 8 months ago.

Viewing 4 posts - 1 through 4 (of 4 total)
  • Author
    Posts
  • #859

    pfalcon
    Member

    .. in 4ea8b520b80d05a199a555d9be67ed8ed5ee2e06
    I’m not sure that’s great idea. Maybe last change would affect how it is implemented, but having such feature is useful. In particular, I have a patch in my fork repo that make -p foo –clean do what is expected…

    #869

    CiaranG
    Member

    All clean ever used to do was completely remove the entire directory of built apk files, causing the everything in the repo to be rebuilt from source. Rarely, if ever, a good idea.

    Happy to merge the above patch though if you point me in the right direction.

    #877

    pfalcon
    Member

    Yes, complete wipe is of little use, but rebuilding single project from scratch helps much when hacking on that project or build.py itself ;-) .

    I would need to clean it up/recover –clean switch first, will submit merge request then (and that’s just one of bunch more changes I have done, need to open discussion about them one day).

    #879

    CiaranG
    Member

    I just do rm -rf build/package.id, which might even be less characters than ./build.py –clean package.id ;)

    But I guess a dedicated switch is cleaner (ha ha) and more futureproof.

Viewing 4 posts - 1 through 4 (of 4 total)

You must be logged in to reply to this topic.